Repository navigation
ci: validate SignalRGB releases against main - #24
Merged
Merged
Conversation
Assisted-by: OpenAI Codex
Closed
4 tasks done
MAJ224
commented
Oct 27, 2026
MAJ224
left a comment
Collaborator
Author
There was a problem hiding this comment.
Review at head 23df7c0: ready to merge
What was checked
- Checked
.github/workflows/release.yml:26whereactions/checkout@v7now usesfetch-depth: 0to ensure full commit history is available for ancestry queries. - Checked
.github/workflows/release.yml:28-46which validates tag format (^v([0-9]+\.[0-9]+\.[0-9]+)$), verifies thatsrc/FocusRgb.Plugin.SignalRgb/focusrgb-plugin.jsonhasmanifest.version == $tagVersion, fetchesorigin/main, and executesgit merge-base --is-ancestor $env:GITHUB_SHA origin/main. - Traced adversarial cases:
- Tag push on unmerged
developcommit:merge-baseexits with code 1; line 44 intercepts and throws"Release commits must belong to main history.", halting beforedotnet restoreor artifact assembly. - Manifest version mismatch: if a tag
v0.3.0is pushed whilesrc/FocusRgb.Plugin.SignalRgb/focusrgb-plugin.jsonspecifies0.2.0, line 38 aborts before build. - PR / workflow dispatch: non-push events skip the validation block (
if: github.event_name == 'push'), allowing dry-run test builds and packaging verification to proceed cleanly.
- Tag push on unmerged
- Required CI (
branch-policy,build,release) passed at head23df7c0.
What was not checked
- Did not push release tags or publish a GitHub release (manual step).
- Did not perform live hardware RGB illumination tests (manual step).
- Local test execution not run; relied on GitHub Actions CI.
Assisted-by: Antigravity
23 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checks out full history and validates tag pushes before restoring or assembling a release: tags must match vMAJOR.MINOR.PATCH, match the plugin manifest version, and point to origin/main history. Failed fetches and ancestry checks fail closed. PR and workflow_dispatch packaging dry runs remain available without publishing.
Verification: Release build has 0 warnings/errors; 12/12 tests pass. The actual inline guard parses and passes simulated main ancestry while rejecting develop-only/unmerged commits, Git/fetch errors, malformed tags and version mismatches. Build servers shut down. No live output, tags, releases or package publication performed.
Part of FocusRGB/FocusRGB#155. Antigravity: please review.
Assisted-by: OpenAI Codex